Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2546 :Renaming ongoingstory to promoted story #3640

Closed
wants to merge 3 commits into from
Closed

Fix #2546 :Renaming ongoingstory to promoted story #3640

wants to merge 3 commits into from

Conversation

Rohit1173
Copy link
Contributor

Explanation

Fix #2546 :
Renamed ongoingStoryListSummaryResultLiveData => promotedStoryListSummaryResultLiveData
Renamed fun subscribeToOngoingStoryList => fun subscribeToPromotedStoryList
Renamed OngoingStoryViewModel => PromotedStoryViewModel and its usages

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@oppiabot
Copy link

oppiabot bot commented Aug 14, 2021

Hi @Rohit1173, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 3 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Aug 14, 2021
@rt4914
Copy link
Contributor

rt4914 commented Aug 16, 2021

@Rohit1173 Can you have a look at #2794 and based on this update your PR?

@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Aug 16, 2021
@oppiabot
Copy link

oppiabot bot commented Aug 23, 2021

Hi @Rohit1173, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 3 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Aug 23, 2021
@oppiabot oppiabot bot closed this Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenHenning BenHenning Awaiting requested review from BenHenning

@rt4914 rt4914 Awaiting requested review from rt4914

Assignees

@Rohit1173 Rohit1173

Labels
stale Corresponds to items that haven't seen a recent update and may be automatically closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename OngoingStory to PromotedStory
2 participants
@Rohit1173 @rt4914